This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Create cold wallet references #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mederic-p
force-pushed
the
1091-cold-wallet-reference
branch
from
bb85d27
to
92d76bb
Compare
mederic-p
changed the title
added 8 commits
July 15, 2019 12:30
mederic-p
force-pushed
the
1091-cold-wallet-reference
branch
from
92d76bb
to
b682539
Compare
unnawut
reviewed
Jul 22, 2019
apps/admin_api/lib/admin_api/v1/controllers/blockchain_wallet_controller.ex
Outdated
Show resolved
Hide resolved
apps/admin_api/lib/admin_api/v1/controllers/blockchain_wallet_controller.ex
Outdated
Show resolved
Hide resolved
| @@ -103,7 +134,27 @@ defmodule EWalletDB.BlockchainWallet do | |||
| @spec insert(map()) :: {:ok, %__MODULE__{}} | |||
| def insert(attrs) do | |||
There was a problem hiding this comment.
Do we still have any case where we insert a wallet that is both not hot nor cold? Might be able to remove this.
There was a problem hiding this comment.
Noted that it's being used by the test helpers. Refactor can be done in a separate PR
...et_db/priv/repo/migrations/20190710085358_add_blockchain_identifier_to_blockchain_wallet.exs
Show resolved
Hide resolved
...et_db/priv/repo/migrations/20190710085358_add_blockchain_identifier_to_blockchain_wallet.exs
Show resolved
Hide resolved
unnawut
approved these changes
Jul 24, 2019
T-Dnzt
approved these changes
Jul 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task Number: 695
Closes #695, #1107
Overview
This PR allows the creation of a cold wallet "reference" using
blockchain_wallet.create.Changes
blockchain_wallet.createendpoint and associated files.Implementation Details
The
blockchain_wallet.createendpoints requires aname, anaddressand atype. For now, as we are only supporting cold wallet creation with the API, the giventypemust becold.Usage
The easiest is to test the endpoint in the updated swagger ui.
Impact
N/A