Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Refactor EthBlockchain Adapter #1159

Merged
merged 178 commits into from
Sep 18, 2019
Merged

Refactor EthBlockchain Adapter #1159

merged 178 commits into from
Sep 18, 2019

Conversation

mederic-p
Copy link
Contributor

Issue/Task Number: 1154
Closes #1154

Overview

This PR splits the EthBlockchain.Adapter for more clarity.
Also fixes an issue where EthBlockchain was called directly from admin_api.

mederic and others added 30 commits July 4, 2019 11:51
tmp
78574d9
Add tests
d57b9d2
Add scripts and README to facilitate local testnet setup
d5deb95
Fix typo
d53dedd
Add byzantium block to genesis
6e1fdda
Refactor params to maps instead of tuples
b789120
Fix send transaction
60056f0
Get ERC-20 fields for tokens
5e69ac6
Improve/fix existing code
3e4bfce
Add totalSupply as a valid erc20 field
4d59a1c
Refactor get blockchain balance to return nil if invalid contract
932db5d
Fix geth response parsing
0ecdc58
Add token gate
f407a1b
mix format
b2a673e
Add endpoint to verify erc20 capabilities of an address
27be47a
mix format
557c35f
improve error handling
c28ccce
Add endpoint to set a contract address to a token
90db70d
Prepare the dumb adapter for :get_field
7b94ed3
Remove unused files [ci skip]
2549e6b
Add tests
3bca0ed
update tests [ci skip]
157c975
Silence warning
a055e7b
Add blockchain seeds
5fe852f
Update swagger
9a390fd
Update create token to support blockchain address
7109f31
Implement functional blockchain transaction flow
2c8470b
Test and refactor modules on eWallet side
b189407
Add tests for blockchain registry
69c1db7
Add tests / cleanup blockchain tx flow
a3fd3c0
@mederic-p mederic-p added kind/refactor ⚙️ This is only about refactoring, no new feature. flag/ethereum integration location/backend labels Sep 13, 2019
@mederic-p mederic-p added this to the v2.0 milestone Sep 13, 2019
@mederic-p mederic-p self-assigned this Sep 13, 2019
@T-Dnzt T-Dnzt added this to 4-Review in eWallet via automation Sep 13, 2019
unnawut
unnawut approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@unnawut unnawut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍👍👍

apps/eth_blockchain/lib/eth_blockchain/adapter_server.ex Outdated Show resolved Hide resolved
@mederic-p mederic-p changed the base branch from 1149-prepare-blockchain-token-minting to eth-blockchain September 18, 2019 06:15
@mederic-p mederic-p merged commit ee2421d into eth-blockchain Sep 18, 2019
eWallet automation moved this from 4-Review to 5-Done Sep 18, 2019
@mederic-p mederic-p deleted the 1154-refactor-eth-adapter branch September 18, 2019 06:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@unnawut unnawut unnawut approved these changes

@T-Dnzt T-Dnzt T-Dnzt approved these changes

Assignees

@mederic-p mederic-p

Labels
flag/ethereum integration kind/refactor ⚙️ This is only about refactoring, no new feature. location/backend
Projects
eWallet
  
5-Done
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mederic-p @unnawut @T-Dnzt