This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Make blockchain addresses case insensitive #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mederic-p
force-pushed
the
1160-address-case-insensitive
branch
from
0d0b220
to
3caa1ea
Compare
|
When user sends in a mixed case address, there's some expectation that the address is The address can be saved as all lowercase in the database I think, easier for search. I see Etherscan actually does that too, pass the address around as lower case and only encoding back to mixed case on display. |
mederic-p
changed the title
unnawut
reviewed
Sep 16, 2019
apps/ewallet_db/priv/repo/migrations/20190916055803_update_address_case.exs
Outdated
Show resolved
Hide resolved
unnawut
approved these changes
Sep 16, 2019
T-Dnzt
approved these changes
Sep 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task Number: 1160
Closes #1160
Overview
This PR updates the db column of stored blockchain address to be case insensitive so they can be searched given a string ignoring its case.
It also force downcase blockchain addresses before saving them in the DB.