Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Added formatted_id to simplify transaction request flow #221

Merged
merged 1 commit into from Jun 5, 2018
Merged

Added formatted_id to simplify transaction request flow #221

merged 1 commit into from Jun 5, 2018

Conversation

T-Dnzt
Copy link

@T-Dnzt T-Dnzt commented Jun 5, 2018

Issue/Task Number: T350

Overview

Currently, the client is responsible for formatting and storing data inside the QR code before decrypting and sending them. The server should take care of that to make it easier to upgrade the format.

Changes

  • Change request_id and id to formatted_transaction_request_id
  • Add formatted_id to TransactionRequest serializer which can be directly encoded in a QR code and sent when consuming in formatted_transaction_request_id

@T-Dnzt T-Dnzt requested review from unnawut and mederic-p June 5, 2018 05:52
@T-Dnzt T-Dnzt merged commit 49f2c53 into develop Jun 5, 2018
@T-Dnzt T-Dnzt deleted the T350-formatted-id branch June 5, 2018 07:22
@mederic-p mederic-p mentioned this pull request Jun 5, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@unnawut unnawut unnawut approved these changes

@mederic-p mederic-p mederic-p approved these changes

Assignees

@unnawut unnawut

@T-Dnzt T-Dnzt

@mederic-p mederic-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@T-Dnzt @unnawut @mederic-p