Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Simplify create request design #510

Merged
merged 19 commits into from
Nov 15, 2018
Merged

Simplify create request design #510

merged 19 commits into from
Nov 15, 2018

Conversation

jarindr
Copy link
Contributor

@jarindr jarindr commented Nov 6, 2018

Issue/Task Number: #412

Overview

This PR Simplify create request design and fix minor bugs.

Changes

  • Simplify create request design.
  • Fix expiration date bug not working.

Impact

Deploy as usual.

screen shot 2018-11-06 at 7 41 11 pm

@ghost ghost assigned jarindr Nov 6, 2018
@ghost ghost added the s2/wip 🚧 label Nov 6, 2018
@jarindr jarindr added this to To Do in eWallet Team via automation Nov 6, 2018
@jarindr jarindr removed this from To Do in eWallet Team Nov 6, 2018
@jarindr jarindr added p2/normal This is something that should be done kind/enhancement 🚀 New feature or request labels Nov 8, 2018
@mederic-p
Copy link
Contributor

Will test this asap after I finish my task

@jarindr
Copy link
Contributor Author

jarindr commented Nov 12, 2018

@mederic-p fixed the bug you mentioned.

@T-Dnzt
Copy link

T-Dnzt commented Nov 14, 2018

Can we add an highlight of the currently selected transaction request? And show the transaction request ID in the properties? For now it's hard to associate which transaction request from the list is currently opened.

@T-Dnzt T-Dnzt merged commit 0ef86c9 into master Nov 15, 2018
@T-Dnzt T-Dnzt deleted the 412-simplify-create-request branch November 15, 2018 04:20
@ghost ghost removed the s3/review 👀 label Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement 🚀 New feature or request p2/normal This is something that should be done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants