This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Fix error 500 when trying to filter a disallowed field on /api/admin/account.get_wallets #514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #513
Overview
This PR fixes the issue with filtering a disallowed field on
/api/admin/account.get_wallets
.Changes
Orchestrator.build_query/3
to usewith
clause instead of pipes to catch errors mid-way.WalletOverlay
that should useself_filter_fields()
instead ofdefault_preload_assocs()
for figuring out the allowed filter fields.Implementation Details
Because
Orchestrator.build_query/3
was using pipes, this makes it hard to handle error if it is returned midway. This PR changed it to usewith
clauses.Also,
WalletOverlay
was usingdefault_preload_assocs()
to build the filters instead ofself_filter_fields()
.Usage
Making a request like following should return the proper results:
Impact
No DB or API changes