This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Skip settings migration if the settings value has not been changed #874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task Number: #798
Closes #798
Overview
This PR skips migration of a specific settings if the settings value has not been changed.
This helps remove unnecessary database writes and activity logs caused by unchanged settings updates.
Changes
EWallet.ReleaseTasks.ConfigMigration
to skip updating if a settings value is unchanged.Implementation Details
The
Settings
andStoredSettings
is pretty complicated and adds a lot of changes to the changeset. Since this settings migration command mainly takes ENV values and saves to database, this PR skips unnecessary DB updates by checking whether the settings value changed. Only if it changed then it proceeds with the update.Usage
Running this command the first time:
Would result in:
However, running it with the same value again would result in:
Impact
No changes to API specs or DB schemas.