This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
Frontend lint release version #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Dnzt
approved these changes
Apr 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task Number: #945, #972
Run frontend linting (
npm run lint) as part of the build process, as well as automatically update versions inmix.exsduring build process. The version number will be either:1.2.0-pre.0forv1.2.0-pre.0tag, prefixvtruncated1.2.0-pre.0-18-g343a6c80The latter is generated using
git describe --tags. SHA hash for the commit is after thegletter.This commit also fixes #971 where config command fails due to
KEYCHAIN_SECRET_KEYnot properly getting configured during E2E.