Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Exchange pair default address #973

Merged
merged 10 commits into from
Apr 30, 2019
Merged

Conversation

T-Dnzt
Copy link

@T-Dnzt T-Dnzt commented Apr 26, 2019

Issue/Task Number: #968
closes #968

Overview

This PR adds two new fields to exchange pairs:

  • default_exchange_wallet_address: The address of a wallet that can be used for exchange when using the given exchange pair.
  • allow_end_user_exchanges: A boolean defining whether or not end users are able to exchange (using the default address above) by themselves without intervention from an admin user.

@T-Dnzt T-Dnzt requested review from unnawut, mederic-p and nicholasmueller and removed request for mederic-p April 26, 2019 03:05
@T-Dnzt T-Dnzt added kind/enhancement 🚀 New feature or request and removed s2/wip 🚧 labels Apr 26, 2019
@T-Dnzt T-Dnzt requested a review from mederic-p April 26, 2019 03:07
Copy link
Contributor

@unnawut unnawut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed the backend part. Some questions...

@jarindr jarindr merged commit b4de2d1 into v1.3 Apr 30, 2019
@jarindr jarindr deleted the 968-exchange-pair-default-address branch April 30, 2019 08:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement 🚀 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants