New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Carthage installation #17
Support Carthage installation #17
Conversation
Hi, thanks for contributing to the project! |
@mederic-p Thank you for the review.
This makes total sense for me too. I removed the build framework from the repository.
I meant to drag the framework to the project by |
README.md
Outdated
carthage update --platform ios | ||
``` | ||
|
||
Drag `OmiseGo` in the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd put:
Drag the built OmiseGO.framework
into your Xcode project.
For maximum clarity :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor wording change
@mederic-p fixed 👍 |
Issue/Task Number: Link
Overview
Supports SDK installation via Carthage.
Changes
Implementation Details
I make changes to support installation via Carthage.
Usage
Cartfile
in some directory and addgithub "omisego/ios-sdk"
, then runcarthage update --platform ios
Carthage
and put the built framework in it.OmiseGo
framework to the project and run.Impact
None