Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift4.1 #24

Merged
merged 2 commits into from Apr 2, 2018
Merged

Swift4.1 #24

merged 2 commits into from Apr 2, 2018

Conversation

mederic-p
Copy link
Contributor

Issue/Task Number: 184

Overview

Apple released a new swift version, the PR update the project file to swift 4.1 and fixes a small warning.

Changes

  • Update project file
  • Fixes new warning
  • update Readme

Implementation Details

Usage

Impact

Projects that integrate the SDK need to be updated to swift 4.1 (shouldn't be an issue)

@mederic-p mederic-p requested review from T-Dnzt and ripzery April 2, 2018 08:24
@T-Dnzt T-Dnzt removed their assignment Apr 2, 2018
@ripzery ripzery removed their assignment Apr 2, 2018
@mederic-p mederic-p changed the base branch from websockets to master April 2, 2018 09:57
@mederic-p mederic-p merged commit 3c350c7 into master Apr 2, 2018
@mederic-p mederic-p deleted the swift4.1 branch April 2, 2018 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Dnzt T-Dnzt T-Dnzt approved these changes

@ripzery ripzery ripzery approved these changes

Assignees

@mederic-p mederic-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mederic-p @T-Dnzt @ripzery