Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T209 update transaction request and consumption params #31

Merged
merged 2 commits into from Apr 17, 2018
Merged

T209 update transaction request and consumption params #31

merged 2 commits into from Apr 17, 2018

Conversation

mederic-p
Copy link
Contributor

Issue/Task Number: 209

Overview

This PR adjusts the params for TransactionRequest and TransactionConsumptionParams

Changes

  • Make address not optional in TransactionRequest
  • Remove expirationDate from TransactionConsumptionParams

@mederic-p mederic-p requested a review from T-Dnzt April 10, 2018 03:21
@T-Dnzt T-Dnzt removed their assignment Apr 17, 2018
@mederic-p mederic-p merged commit 38df779 into master Apr 17, 2018
@mederic-p mederic-p deleted the T209-update-request-params branch April 17, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Dnzt T-Dnzt T-Dnzt approved these changes

Assignees

@mederic-p mederic-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mederic-p @T-Dnzt