Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T160 update pagination params #36

Merged
merged 2 commits into from Apr 25, 2018
Merged

T160 update pagination params #36

merged 2 commits into from Apr 25, 2018

Conversation

mederic-p
Copy link
Contributor

Issue/Task Number: 160

Overview

This PR split the init of the pagination params in order to avoid confusion as searchTerm and searchTerms can't work together.

Changes

  • Split init
  • Update socket events

@T-Dnzt T-Dnzt removed their assignment Apr 24, 2018
@mederic-p mederic-p force-pushed the T160-update-pagination-params branch from 2deea26 to e04dd12 Compare April 25, 2018 03:29
@mederic-p mederic-p merged commit 4aa45ad into master Apr 25, 2018
@mederic-p mederic-p deleted the T160-update-pagination-params branch April 25, 2018 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Dnzt T-Dnzt T-Dnzt approved these changes

@ripzery ripzery Awaiting requested review from ripzery

Assignees

@ripzery ripzery

@mederic-p mederic-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mederic-p @T-Dnzt @ripzery