Remove updatedAt from transactions #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripzery
reviewed
May 14, 2018
| - `sortDir` is the sorting direction. Available values: `.ascending`, `.descending` | ||
| - `searchTerm` is a term to search for in ALL of the searchable fields. Conflict with search_terms, only use one of them. See list of searchable fields below (same as search_terms). | ||
| - `searchTerms` is a dictionary of fields to search in with the following available fields: `.id`, `.status`, `.from`, `.to`, `.createdAt`, `.updatedAt`. Ex: `[.from: "someAddress", .id: "someId"]` |
There was a problem hiding this comment.
It's actually not supported by the API so it shouldn't be here :)
ripzery
approved these changes
May 15, 2018
T-Dnzt
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task Number: 282
Overview
This PR removes the
updatedAtattribute and its related uses fromTransaction.Changes
updatedAtattribute fromTransactionmodelTransactionImplementation Details
Transaction can't be updated so there is no need for the
updatedAtattribute.Impact
Once removed from the API, older version of the SDK will not work anymore.