Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove idempotency token from header (put it in params) #58

Merged
merged 2 commits into from Jun 18, 2018
Merged

Remove idempotency token from header (put it in params) #58

merged 2 commits into from Jun 18, 2018

Conversation

mederic-p
Copy link
Contributor

Issue/Task Number: 407

Overview

This PR moves the idempotency token from header to params (following this PR)

Changes

  • Remove Idempotency token from header
  • Add Idempotency token to params

@mederic-p mederic-p requested review from T-Dnzt and ripzery June 15, 2018 03:41
@T-Dnzt T-Dnzt removed their assignment Jun 15, 2018
@mederic-p mederic-p force-pushed the T407-move-idempotency-token branch from b6f371b to 8bc4aed Compare June 18, 2018 02:54
@mederic-p
Add db:inserted_transaction_could_not_be_loaded error (#57)
2264594 
* Add db:inserted_transaction_could_not_be_loaded error

* Rename accessToken to authentication token error
@mederic-p mederic-p changed the base branch from master to T409-update-endpoints June 18, 2018 03:04
@mederic-p mederic-p merged commit c0b537d into T409-update-endpoints Jun 18, 2018
@mederic-p mederic-p deleted the T407-move-idempotency-token branch June 18, 2018 03:19
mederic-p added a commit that referenced this pull request Jun 18, 2018
@mederic-p
Update endpoint paths (#60)
bce01d8 
* Update endpoint path

* Remove idempotency token from header (put it in params) (#58)

* Update errors (#57)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Dnzt T-Dnzt T-Dnzt approved these changes

@ripzery ripzery Awaiting requested review from ripzery

Assignees

@ripzery ripzery

@mederic-p mederic-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mederic-p @T-Dnzt @ripzery