T415 bigint #61
Merged
T415 bigint #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripzery
approved these changes
Jun 21, 2018
ripzery
reviewed
Jun 21, 2018
| @@ -0,0 +1,108 @@ | |||
| // | |||
| // OMGNumberFormatter.swift | |||
| // OmiseGOTests | |||
There was a problem hiding this comment.
A small thing, Is it should be OmiseGO instead of OmiseGOTests?
T-Dnzt
approved these changes
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task Number: 415
Overview
The current version of the SDK uses Double to store the different amounts of transactions.
There is a problem with precision when the number becomes too big.
This PR adds the BigInt library and convert all
DoubletoBigInttype.This allow the coding / decoding of numbers with up to 38 digits. If the value in the JSON contains more than 38 digits, we raise an error. That's also the case when we try to make a transaction with an overly big amount.
Changes
DoubletoBigIntwhen neededsubunitToUnittype toUInt64which allows to store up to 19 digits