Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing attributes #80

Merged
merged 6 commits into from Sep 14, 2018
Merged

Add missing attributes #80

merged 6 commits into from Sep 14, 2018

Conversation

mederic-p
Copy link
Contributor

Closes #79

Overview

This PR adds some missing attributes and renames some variables.

Changes

  • Add user and account to TransactionSource
  • Rename redirectURL to successURL (following API update)
  • Make account description optional

@ghost ghost added the s2/wip 🚧 This is still being worked on label Sep 13, 2018
@mederic-p mederic-p merged commit 45af014 into master Sep 14, 2018
@ghost ghost removed the s2/wip 🚧 This is still being worked on label Sep 14, 2018
@mederic-p mederic-p deleted the 79-add-missing-attributes branch September 14, 2018 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Dnzt T-Dnzt T-Dnzt approved these changes

@ripzery ripzery ripzery approved these changes

Assignees

@T-Dnzt T-Dnzt

@ripzery ripzery

@mederic-p mederic-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mederic-p @T-Dnzt @ripzery