Improve live tests #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mederic-p
force-pushed
the
T825-Improve-live-tests
branch
from
06fdb36
to
67a24a5
Compare
T-Dnzt
previously approved these changes
Feb 27, 2018
mederic-p
force-pushed
the
T820-list-transactions
branch
from
3ecf9e9
to
696766f
Compare
mederic-p
force-pushed
the
T825-Improve-live-tests
branch
from
67a24a5
to
96a6f18
Compare
ripzery
previously approved these changes
Feb 27, 2018
mederic-p
force-pushed
the
T825-Improve-live-tests
branch
from
96a6f18
to
022351c
Compare
T-Dnzt
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task number T825
Overview
This PR improve live tests by moving all live credentials to a secret.plist file.
It also fixes an issue with the transaction consume and adds live tests to it.
Changes
Usage
No major change, just the addition of mintedTokenId in the transactionConsumeParams that require an update of the readme. For the rest, just run the updated tests.