fix: do not require position to have output index when encoding a tx …

…position value from it
omgnetwork · Dec 11, 2019 · 2e06d16 · 2e06d16
1 parent f5daf93
commit 2e06d16
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/plasma_framework/contracts/src/utils/PosLib.sol b/plasma_framework/contracts/src/utils/PosLib.sol
@@ -61,7 +61,6 @@ library PosLib {
      * @return Position encoded as an integer
      */
     function encodePackedTxPos(Position memory pos) internal pure returns (uint256) {
-        require(pos.outputIndex == 0, "Invalid transaction position");
         return pos.blockNum * BLOCK_OFFSET + pos.txIndex * TX_OFFSET;
     }
 

diff --git a/plasma_framework/test/src/utils/PosLib.test.js b/plasma_framework/test/src/utils/PosLib.test.js
@@ -55,21 +55,9 @@ contract('PosLib', () => {
 
     describe('encodePackedTxPos', () => {
         it('should encode a tx position', async () => {
-            const txPos = {
-                blockNum: this.blockNumber,
-                txIndex: this.txIndex,
-                outputIndex: 0,
-            };
-            const result = await this.contract.encodePackedTxPos(txPos);
+            const result = await this.contract.encodePackedTxPos(this.position);
             expect(result).to.be.bignumber.equal(new BN(this.txPos));
         });
-
-        it('should fail when invalid position is provided as argument', async () => {
-            await expectRevert(
-                this.contract.encodePackedTxPos(this.position),
-                'Invalid transaction position',
-            );
-        });
     });
 
     describe('decode', () => {