CI pipeline #24
Merged
CI pipeline #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unnawut
added
kind/enhancement 🚀
0x234
reviewed
Jun 18, 2019
sirn
suggested changes
Jun 19, 2019
added 7 commits
June 19, 2019 19:25
sirn
reviewed
Jun 19, 2019
added 2 commits
June 19, 2019 20:16
added 7 commits
June 19, 2019 20:46
Merged
InoMurko
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Task Number: #10, #21
Closes #10
Closes #21
Overview
This PR sets up the CI pipeline so potterhat gets to build, lint, test, dialyze and deploy automatically.
Changes
update-versions.shso subapp versions get updated automatically (copied from ewallet)Makefileto manage build tasks.circleci/*files for the CI stepsrootfs/*andrel/*files for distilleryDockerfileto support releasesImplementation Details
Pretty much copy paste from other OmiseGO apps with minor edits.
Notes:
.circleci/*files that have separated a lot of commands into its own script files, but synced back to be on par with all the build steps existing in the eWallet.omisegoimages/ewallet-builder:stablefor the build image andomisegoimages/ewallet-deploy:stablefor deploy image. Not sure if potterhat also needs its own images.Usage
With this PR landed, we should be able to setup CircleCI workflow for this repo & start seeing images on Docker Hub.
Impact
Shiny new stuff. Only breaks itself.