Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce int primitive type for enum #126

Merged
merged 3 commits into from
Sep 30, 2023

Conversation

omissis
Copy link
Owner

@omissis omissis commented Sep 30, 2023

  • Adds enforcing integer type for enum values
  • Fixes linter complains

@omissis omissis self-assigned this Sep 30, 2023
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (5362d2e) 77.85% compared to head (1eccf52) 61.84%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #126       +/-   ##
===========================================
- Coverage   77.85%   61.84%   -16.01%     
===========================================
  Files          12       23       +11     
  Lines        1567     2034      +467     
===========================================
+ Hits         1220     1258       +38     
- Misses        270      692      +422     
- Partials       77       84        +7     
Files Coverage Δ
tests/data/validation/6.1.2_enum.go 0.00% <ø> (ø)
tests/data/validation/6.3.1_maxLength.go 71.42% <ø> (ø)
tests/data/validation/6.3.2_minLength.go 71.42% <ø> (ø)
pkg/generator/generate.go 75.77% <71.42%> (-0.04%) ⬇️
tests/utils.go 16.66% <16.66%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omissis
Copy link
Owner Author

omissis commented Sep 30, 2023

This PR replaces #103 (simply rebases it and fixes an issue coming from main`

@omissis omissis merged commit 3457924 into main Sep 30, 2023
1 of 3 checks passed
@omissis omissis deleted the enforce_int_primitive_type_for_enum branch September 30, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants