Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added media extension ala: https://docs.djangoproject.com/en/2.0/topi… #25

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

ogtony
Copy link
Contributor

@ogtony ogtony commented Mar 16, 2018

Fixes #23

@coveralls
Copy link

coveralls commented Mar 16, 2018

Coverage Status

Coverage increased (+0.08%) to 89.971% when pulling 8bac5bf on ogtony:master into bc49520 on omji:master.

@cyberbudy
Copy link

Any progress on it?

@ogtony
Copy link
Contributor Author

ogtony commented May 11, 2018

Are you asking me?
I can tell you this branch works and I am using it in a beta Django 2.0 site just fine if you want to work off my commit until the maintainers come and look around.

@dfalling
Copy link

This works for me as well with Django 2.0.3. Can we get some eyes on this by the maintainers? I'd love to see this merged in.

@ghost
Copy link

ghost commented May 25, 2018

I can't get it to work here. Am I doing it right ?

Pipfile :

[packages]
django-tabbed-admin = { git = 'https://github.com/omji/django-tabbed-admin.git', ref = '8bac5bf138bdbcc624708412b38f253c3cf04855' }

Then :

pipenv install --dev

In settings :

TABBED_ADMIN_USE_JQUERY_UI = True

Getting this error message in the JS console :

(index):1440 Uncaught TypeError: $(...).tabs is not a function
    at (index):1440
    at (index):1475
(anonymous) @ (index):1440
(anonymous) @ (index):1475

How can I resolve this ?

Thanks !

@jox
Copy link
Contributor

jox commented Jun 30, 2018

Works well here with Django 2.0.6 and Grappelli 2.11.1. Thanks!
Maintainers, please maintain! :-)

@Gedzis
Copy link

Gedzis commented Jul 2, 2018

@omji can you merge this?

@omji omji merged commit 05f35e2 into omji:master Jul 2, 2018
@omji
Copy link
Owner

omji commented Jul 2, 2018

Thanks a million guys! Sorry for the silence, but I have some insane workload nowadays. If anyone wants to take over some admin role on this project that would be awesome!

@omji
Copy link
Owner

omji commented Jul 2, 2018

I ll try to push a new version on Pypi today or tomorow! Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants