since the ast AnnAssign class can be value-less, avoid resolution fai… #148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks so much to everyone in the community (especially @mauvilsa !) for this immensely valuable package!
This PR fixes #147.
What does this PR do?
According to the current cpython abstract grammar definition, the value of an
ast.AnnAssign
class can beNone
(also discussed in PEP 526) whether within methods or in the class body. So though it's usually considered bad practice stylistically, since it's valid syntax, AST-based parameter resolution should handle this edge case I think.I've written a tiny one-line fix for this issue and added an associated test in the parameter-resolver test module.
In case it's relevant, an alternate approach to testing that I validated was to simply add a value-less annotation within the
__init__
method of ClassA but I ultimately decided that isolating the test the way I've done in this PR might make more sense.