Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of new bridge mode: ERC20 to Native #81

Closed
5 tasks
akolotov opened this issue Sep 17, 2018 · 1 comment
Closed
5 tasks

Support of new bridge mode: ERC20 to Native #81

akolotov opened this issue Sep 17, 2018 · 1 comment
Assignees
@patitonar

Comments

@akolotov
Copy link
Collaborator

In order to implement a new bridge mode described in https://hackmd.io/s/Bk9icHBd7, omni/tokenbridge-contracts#79 was created for the changes on the bridge contracts side.

This issue was created to address necessary modification on bridge process side. The intermediate list of changes:

  • Adapt the initialization code to determine the bridge mode. The current version of code uses BRIDGE_MODE parameter but it makes sense to consider selectors of contracts' methods specific for particular bridge mode
  • Improve configs
  • improve scripts
  • Add e2e tests
  • Update README
@akolotov akolotov mentioned this issue Sep 17, 2018
Closed
@ghost ghost assigned patitonar Sep 26, 2018
@ghost ghost added the in progress label Sep 26, 2018
@patitonar patitonar mentioned this issue Sep 26, 2018
Merged
@ghost ghost added review and removed in progress labels Sep 26, 2018
patitonar added a commit that referenced this issue Oct 9, 2018
@patitonar
Merge branch 'develop' into support-erc20-native-#81
6bdf661 
# Conflicts:
#	README.md
patitonar added a commit that referenced this issue Oct 9, 2018
@patitonar
Merge branch 'develop' into support-erc20-native-#81
cbeab85 
# Conflicts:
#	e2e/Dockerfile
fvictorio added a commit that referenced this issue Oct 16, 2018
@fvictorio
Merge branch 'develop' into support-erc20-native-#81
61f8fb7
fvictorio added a commit that referenced this issue Oct 22, 2018
@fvictorio
Merge branch 'support-erc20-native-#81' into add-watchdog
0cd7385
patitonar added a commit that referenced this issue Oct 25, 2018
@patitonar
Merge branch 'support-erc20-native-#81' into add-watchdog
597675e
patitonar referenced this issue Oct 29, 2018
@patitonar
Merge pull request #85 from poanetwork/support-erc20-native-#81
7069ef9 
Add support ERC20 to Native
@akolotov
Copy link
Collaborator Author

Addressed in #85

@ghost ghost removed the review label Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patitonar patitonar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patitonar @akolotov