New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security review fixes #119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead rabbit:3-management. Added files to .dockerignore.
…s and rabbitmq container restart policy to 'unless-stoped'
patitonar
approved these changes
Dec 13, 2018
phahulin
approved these changes
Dec 13, 2018
akolotov
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cumulative update that fixes some of the critical issues that were found during security audit.
As for https://github.com/poanetwork/token-bridge#rollback-the-last-processed-block-in-redis and https://github.com/poanetwork/token-bridge#native-to-erc20-mode-testing. I might be mistaking, but I didn't find anything to fix. We still have the
bridge
service which can be used as the part of the commands at the ReadMe.References:
#116
#113