Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use chainId on sender instead of networkId #136

Merged
merged 5 commits into from Mar 23, 2019
Merged

Use chainId on sender instead of networkId #136

merged 5 commits into from Mar 23, 2019

Conversation

patitonar
Copy link

Closes #134

@patitonar patitonar requested a review from akolotov March 22, 2019 13:44
@ghost ghost assigned patitonar Mar 22, 2019
@ghost ghost added the review label Mar 22, 2019
@patitonar
Copy link
Author

patitonar commented Mar 22, 2019 •
edited

I had to update the parity version we were using on the e2e tests. eth_chainId method was implemented on version Parity-Ethereum v2.2.1 (2018-11-15). Also fixed the version of web3 as we did on bridge-ui and the contracts repo to avoid any breaking change.

@akolotov akolotov merged commit b565569 into develop Mar 23, 2019
@ghost ghost removed the review label Mar 23, 2019
@akolotov akolotov mentioned this pull request Apr 1, 2019
Merged
@patitonar patitonar deleted the use-chainId-instead-of-networkId branch April 26, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akolotov akolotov akolotov approved these changes

Assignees

@patitonar patitonar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patitonar @akolotov