Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

target 2.2.0 bridges contracts instead of 2.1.0 in e2e tests #140

Merged
merged 1 commit into from Apr 10, 2019
Merged

target 2.2.0 bridges contracts instead of 2.1.0 in e2e tests #140

merged 1 commit into from Apr 10, 2019

Conversation

branciard
Copy link

Hi,
I do not know if it is intentional but the current e2e tests in develop branch target the 2.1.0 contracts release and not the latests 2.2.0 one.

I updated to 2.2.0 and have to fix some configs :

  • increase DEPLOYMENT_GAS_LIMIT to pass for some contracts deployment.
  • rename HOME_OWNER_MULTISIG to HOME_BRIDGE_OWNER
  • rename HOME_UPGRADEABLE_ADMIN_VALIDATORS to HOME_VALIDATORS_OWNER
  • rename HOME_UPGRADEABLE_ADMIN_BRIDGE to HOME_UPGRADEABLE_ADMIN
  • the same renaming for 3 FOREIGN configs
  • Remove DEPLOYMENT_ACCOUNT_ADDRESS in conf and add instead privateKeyToAddress usage.

./run-tests.sh is then ok for me after this config changes.

@akolotov akolotov requested a review from patitonar April 10, 2019 12:09
akolotov
akolotov approved these changes Apr 10, 2019
View reviewed changes
Copy link
Collaborator

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patitonar please take a look

patitonar
patitonar approved these changes Apr 10, 2019
View reviewed changes
Copy link

@patitonar patitonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@akolotov akolotov merged commit 879e5e5 into omni:develop Apr 10, 2019
@branciard
Copy link
Author

Cool. thx for the quick merge !

@branciard branciard deleted the updates-e2e-tests-contracts-target branch April 10, 2019 12:31
@akolotov akolotov mentioned this pull request May 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patitonar patitonar patitonar approved these changes

@akolotov akolotov akolotov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@branciard @patitonar @akolotov