-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Travis builds using appraisal gem #113
Conversation
It's worth noting that Travis is now running tests for three Gemfiles for MRI version 2.2, 2.3, and If we decide to reduce the number of RVM/Gemfile combinations being tested, we can speed up the time needed for Travis to complete. |
1 similar comment
Looking closer at the |
I've amended this branch to only have |
This commit fixes the Travis builds by using different gemfiles for different versions of Ruby and some gem dependencies (notably rack 1.x and 2.x). These gemfiles are managed by the `appraisal` gem. It also switches our build matrix from testing with `jruby-head` to testing with `jruby-9.0.5.0`, since `jruby-head` has some issues with `bundler` not being installed. In addition to these changes, I have also enabled Travis's caching feature for Bundler. Hopefully this should speed up our test runs once the caches are primed.
Travis! Y u |
Looks like this was broken because the build picked up a breaking change between I think I'll wait until the |
I released hashie 3.4.6, please check it out. |
Thanks @dblock! I appreciate the proactive heads-up |
I think this is ready to merge. The Coveralls coverage reported here is not what it shows on the site, probably because I restarted the Travis build without pushing any new commits. I you look at the site, it shows a %2 drop to %94 and the differences look like differences between how coverage is reported across Ruby versions. |
Thanks @md5! |
This PR fixes the Travis builds by using different gemfiles for different versions of Ruby and some gem dependencies (notably
rack
1.x and 2.x). These gemfiles are managed by theappraisal
gem.It also switches our build matrix from testing with
jruby-head
to testing withjruby-9.0.5.0
, sincejruby-head
has some issues withbundler
not being installed.In addition to these changes, I have also enabled Travis's caching feature for Bundler. Hopefully this should speed up our test runs once the caches are primed. In my testing, it appears to have cut the aggregate build time by about a third.