Rework .travis.yml #186
Merged
Rework .travis.yml #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bufferoverflow
force-pushed
the
fix/jruby-build
branch
from
23d9b30
to
a69bf33
Compare
This is more or less a revert of bbc29c0
toupeira
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
@bufferoverflow LGTM! 👍
Not sure about the removal of the appraisal gem, maybe we want to keep it around in case we'll need it again in the future? On the other hand it won't be much effort to add it back, so I really don't have a strong opinion on this 🙂
|
Thanks @toupeira I think we can add the |
|
@md5 @supernova32 Could you review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.