Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruby-saml to 1.1 #66

Merged
merged 1 commit into from
Feb 2, 2016
Merged

Update ruby-saml to 1.1 #66

merged 1 commit into from
Feb 2, 2016

Conversation

suprnova32
Copy link
Member

Ruby SAML 1.1 was released a couple of months ago and includes some important changes, most importantly the support for SAMLResponse without ds:x509certificate.

This is needed for some environments where GitLab EE is running.

Also bumped the version to 1.4.1 to release a new gem.

@md5
Copy link
Contributor

md5 commented Dec 23, 2015

I think this should actually be like this:

gem.add_runtime_dependency 'ruby-saml', '~> 1.1', '>= 1.1.1'

Version 1.1.0 was broken.

@suprnova32
Copy link
Member Author

@md5 good point. I updated the commit.

@suprnova32
Copy link
Member Author

and fixed it again, because I read your comment too fast 😛

@md5
Copy link
Contributor

md5 commented Dec 23, 2015

👍

@dosire
Copy link

dosire commented Dec 24, 2015

@md5 thanks for the feedback, it would be awesome to get this merged.

@suprnova32
Copy link
Member Author

@bpedro any chance we can get this merged soon?

@suprnova32
Copy link
Member Author

@brendankemp any chance we can get this reviewed?

@brendankemp
Copy link

@danwiding is in charge of this project now. He can get you sorted :)

ilikepi added a commit to ilikepi/omniauth-saml that referenced this pull request Jan 26, 2016
@bufferoverflow
Copy link
Member

@danwiding Would you be able to merge this and prepare a new release in the near future?

Thanks a lot!
-roger

@suprnova32
Copy link
Member Author

I guess our only option going forward is to fork this gem, since we have not heard back from the maintainers and the project seems to be abandoned.

danwiding added a commit that referenced this pull request Feb 2, 2016
@danwiding danwiding merged commit f4b6b33 into omniauth:master Feb 2, 2016
@danwiding
Copy link
Contributor

@bufferoverflow @supernova32 @md5 @dosire Hey so I guess I've inherited this. I'll be honest my org has moved away from active maintenance of this gem well before I even joined. I believe @bpedro is the intended maintainer. At any rate, I just granted each of you write privileges to this repo so as to deal with issues like this in the future. However, as a longer term solution I'd like to figure out what org or user account this gem should belong to. If you'd like to take active ownership speak up.

@ilikepi
Copy link
Contributor

ilikepi commented Feb 2, 2016

If no one organization wants to take over maintainership, it might make sense to follow the model adopted for Ryan Bates' CanCan gem. In that case, the community basically created its own organization to hold their fork. They also renamed the gem, presumably since they did not have access to the original on rubygems.org, but perhaps that step would not be necessary in this case.

EDIT: see #67

@ilikepi ilikepi mentioned this pull request Feb 2, 2016
@suprnova32
Copy link
Member Author

@danwiding I would love to take over the maintainership of this gem. I commented on the new issue that @ilikepi created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants