Skip to content

Commit

Permalink
Merge pull request #993 from BobbyMcWho/release-1_9_1
Browse files Browse the repository at this point in the history
Release 1.9.1
  • Loading branch information
BobbyMcWho committed Mar 2, 2020
2 parents 894cb9c + 562bf7a commit fce9e23
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion lib/omniauth/version.rb
@@ -1,3 +1,3 @@
module OmniAuth
VERSION = '1.9.0'.freeze
VERSION = '1.9.1'.freeze
end
2 changes: 1 addition & 1 deletion spec/helper.rb
Expand Up @@ -10,7 +10,7 @@
SimpleCov.start do
add_filter ['/spec/', '/vendor/', 'strategy_macros.rb']
minimum_coverage(92.5)
maximum_coverage_drop(0.01)
maximum_coverage_drop(0.05)
end
end

Expand Down
8 changes: 5 additions & 3 deletions spec/omniauth/strategy_spec.rb
Expand Up @@ -242,7 +242,9 @@ def make_env(path = '/auth/test', props = {})
describe '#redirect' do
it 'uses javascript if :iframe is true' do
response = ExampleStrategy.new(app, :iframe => true).redirect('http://abc.com')
expect(response.last.body.first).to be_include('top.location.href')
expected_body = "<script type='text/javascript' charset='utf-8'>top.location.href = 'http://abc.com';</script>"

expect(response.last).to include(expected_body)
end
end

Expand Down Expand Up @@ -653,8 +655,8 @@ def make_env(path = '/auth/test', props = {})
end

it 'maintains host and port' do
response = strategy.call(make_env('/auth/test', 'rack.url_scheme' => 'http', 'HTTP_HOST' => 'example.org', 'SERVER_PORT' => 3000))
expect(response[1]['Location']).to eq('http://example.org:3000/auth/test/callback')
response = strategy.call(make_env('/auth/test', 'rack.url_scheme' => 'http', 'SERVER_NAME' => 'example.org', 'SERVER_PORT' => 9292))
expect(response[1]['Location']).to eq('http://example.org:9292/auth/test/callback')
end

it 'maintains query string parameters' do
Expand Down

0 comments on commit fce9e23

Please sign in to comment.