2.0.0 changes inbound #1021
Merged
2.0.0 changes inbound #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trategies i.e., prevent it from finding top-level constants
This changes the few instances of "I" to "you" to match the rest of the README.
Previously, it just fetched the global path_prefix.
These messages are very specific to omniauth internals, and thus are only useful when debugging or developing. Having these messages on `:info` causes them to fill test suite output or other non-production logs which are at the `:info` level. We should move these messages to `:debug` so developers can still see them, but they to not pollute non-development logs.
…fault RFC - Make omniauth use post by default
…ssage_key for FailureEndpoint handling Do not rescue around mock_call!
Increase test coverage
…th-hash Remove duplicative eval of credentials and extra
…ndling Generic error handling in Strategy
Remove Hakiri badge
Change first-person to second-person in README
Fix code climate badge
…ookup limit Builder#provider's symbol lookup to constants under OmniAuth::Strategies
Change debugging logging to use debug channel
…n-failure Make the FailureEndpoint respect the strategy's path_prefix.
Frozen string support
Update for frozen-string-literal friendliness.
This commit allows OmniAuth to handle relative url root installations by correctly prefixing the default `Strategy#request_path` and `Strategy#callback_path` with `SCRIPT_NAME` as provided by Rack. Also, in order to detect the full current path, uses `Rack::Request#path` instead of `#path_info`, as the latter does not include SCRIPT_NAME. A deeper question remains: What should happen with custom callback and request paths? I can't think of a case where a user with a relative url root installation would *not* want to prefix its paths, regardless of setting a custom path or not. However, since some people may have configured custom paths in order to deal with relative root, including this change may be breaking.
Deal with relative url root installations
This allows strategies to safely mutate their options without affecting subsequent or concurrent requests.
…-freeze Make sure strategy passes rack freeze
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.