Change debugging logging to use debug channel #949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Indeed, I just came to this repo to figure out how to disable these logs. :) Any ideas? |
These messages are very specific to omniauth internals, and thus are only useful when debugging or developing. Having these messages on `:info` causes them to fill test suite output or other non-production logs which are at the `:info` level. We should move these messages to `:debug` so developers can still see them, but they to not pollute non-development logs.
BobbyMcWho
approved these changes
Dec 10, 2020
Member
|
Triggering CI run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These messages are very specific to omniauth internals, and thus are
only useful when debugging or developing. Having these messages on
:infocauses them to fill test suite output or other non-productionlogs which are at the
:infolevel. We should move these messages to:debugso developers can still see them, but they do not pollutenon-development logs.