Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility issues with rack-protection 3.x #1089

Closed
deepfryed opened this issue Sep 26, 2022 · 5 comments
Closed

Compatibility issues with rack-protection 3.x #1089

deepfryed opened this issue Sep 26, 2022 · 5 comments

Comments

@deepfryed
Copy link

Please complete all sections.

Configuration

  • Provider Gem: omniauth
  • Ruby Version: 3.1.2
  • Framework: N/A
  • Platform: Linux

Expected Behavior

The library should load

Actual Behavior

load error, 'rack-protection' not found

Steps to Reproduce

Setup a ruby or rails app with rack-protection 3.x. The file 'rack-protection.rb' has been renamed to 'rack_protection.rb' in sinatra.
@hieuk09 hieuk09 mentioned this issue Sep 26, 2022
Closed
@nhosoya nhosoya mentioned this issue Sep 26, 2022
Merged
@mvz mvz mentioned this issue Sep 26, 2022
Merged
olleolleolle added a commit to olleolleolle/sinatra that referenced this issue Sep 26, 2022
@olleolleolle
fix: add back a rack-protection.rb file
82b3cf6 
In order to keep compat with earlier files, this wrapper file is needed.

See omniauth/omniauth#1089
@olleolleolle olleolleolle mentioned this issue Sep 26, 2022
Merged
@SebouChu SebouChu mentioned this issue Sep 26, 2022
Closed
@nbibler nbibler mentioned this issue Sep 26, 2022
Closed
@BobbyMcWho
Copy link
Member

Hi, it appears that Sinatra has merged a fix to keep backwards compatibility

@biologistbrian
Copy link

I'm still having this issue though I thought I've updated everything, is there a fix?

@BobbyMcWho
Copy link
Member

If they haven't cut a release, you could point your gem version at their master sha

@BobbyMcWho
Copy link
Member

Looks like 3.0.1 was pushed 3 minutes ago

@biologistbrian
Copy link

Yeehaw! just saw that. yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support rack-protection 3.x
3 participants
@deepfryed @BobbyMcWho @biologistbrian