Try to verify id_token when response_type is code #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naari3
force-pushed
the
verify-when-response_type-is-code
branch
from
a1a539f
to
5914e5e
Compare
|
@m0n9oose Please check this one when you have time :) |
|
@m0n9oose hello, Do you have any ideas? |
|
@naari3 thanks for contributing, Why did you remove |
naari3
force-pushed
the
verify-when-response_type-is-code
branch
2 times, most recently
from
e4b551d
to
d9bd266
Compare
naari3
force-pushed
the
verify-when-response_type-is-code
branch
from
d9bd266
to
970ff0d
Compare
|
@m0n9oose oh sorry I missed it and I fixed one, force pushed now |
|
@m0n9oose Can you check this changes? thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
id_token verification when response_type is
codewas removed by #41 and #28But this is a mistake according to openid connect specs because there must include id_token, then should do verification.