fix(chord chart): remove y-offset of triangle shaped fingers

omnibrain · Jul 19, 2020 · 492358d · 492358d
1 parent ac0b118
commit 492358d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/src/renderer/renderer.ts b/src/renderer/renderer.ts
@@ -15,12 +15,7 @@ export interface GraphcisElement {
 }
 
 export abstract class Renderer {
-  /**
-   * Constant modifier to get the centroid of a equilateral triangle.
-   */
-  protected static readonly TRIANGLE_Y_OFFSET = 0.1547006
-
-  constructor(protected container: QuerySelector | HTMLElement) {}
+  protected constructor(protected container: QuerySelector | HTMLElement) {}
 
   abstract line(
     x1: number,

diff --git a/src/renderer/svgjs/svg-js-renderer.ts b/src/renderer/svgjs/svg-js-renderer.ts
@@ -152,7 +152,7 @@ export class SvgJsRenderer extends Renderer {
   ): GraphcisElement {
     const element = this.svg
       .path(Renderer.trianglePath(x, y, size))
-      .move(x, y - size * Renderer.TRIANGLE_Y_OFFSET)
+      .move(x, y)
       .fill(fill || 'none')
       .stroke({
         width: strokeWidth,