Resolve issues with neverSkipReducer #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
force-pushed
the
fix-neverskipreducer
branch
from
552f49b
to
d8a684c
Compare
aeneasr
force-pushed
the
fix-neverskipreducer
branch
from
d8a684c
to
fcbab32
Compare
This was referenced Nov 17, 2016
|
@arekkas sorry for the late response - it looks fine now 😁 Thanks for the PR! |
|
thanks! |
|
released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for this, I should have created a functional test rather than an integration test only. I did this now, and it should resolve the issues with neverSkipReducer. This won't introduce any bc breaks.