Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading dist and examples to webpack 2 #165

Merged
merged 1 commit into from
Jul 4, 2017
Merged

Upgrading dist and examples to webpack 2 #165

merged 1 commit into from
Jul 4, 2017

Conversation

jcperez-ch
Copy link
Contributor

馃摀 :

  • Use webpack 2 to bundle the UMD distribution.
  • Use webpack 2 to run the examples.

Nothing more, nothing less.

@jcperez-ch
Copy link
Contributor Author

@omnidan I think this is minor, but still something that would happen eventually. Let me know your thoughts.

@jcperez-ch
Copy link
Contributor Author

@davidroeca comments?

@davidroeca
Copy link
Collaborator

@jcperez-ch I have no qualms here but I'm not very well-acquainted with the publishing process (or is it automatic on a version change?)

I'd say we should wait on @omnidan since he set it up

@jcperez-ch
Copy link
Contributor Author

@omnidan any updates for this one?

@omnidan
Copy link
Owner

omnidan commented Jul 4, 2017

@jcperez-ch @davidroeca sorry it took so long - looks good to me and the examples still seem to work, merging 馃榿 thanks for the PR!

@omnidan omnidan merged commit 4be0365 into omnidan:master Jul 4, 2017
@omnidan
Copy link
Owner

omnidan commented Jul 4, 2017

released beta9-9-3 with this PR merged

@omnidan omnidan mentioned this pull request Jul 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcperez-ch @davidroeca @omnidan