Only call groupBy for actions that aren't filtered #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to propose a very small behavior change before the big 1.0:
Currently,
groupBy
is called for every action, even actions that are filtered. This change would only callgroupBy
when necessary, specifically, only for actions that are not filtered and will affect the history.This is more of a logical/contractual change than anything else, but it would provide a small performance boost in the case of complex grouping logic. I'm proposing this change mainly because I was surprised
groupBy
was called for every action, and then I realizedgroupBy
has no idea if the action was filtered or not, so I had to move some of my grouping logic into thefilter
option.