Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinct state fixes #59

Closed
wants to merge 2 commits into from
Closed

Distinct state fixes #59

wants to merge 2 commits into from

Conversation

teameh
Copy link
Collaborator

@teameh teameh commented Mar 11, 2016

I think this fixes the distinctState problem.

All actions are recorded again, like before until you add the distinct filter

teameh
teameh reviewed Mar 11, 2016
View reviewed changes
src/index.js
let history
if (!config.history) {
debug('create history on init')
justCreatedHistory = true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set flag for later

@teameh teameh mentioned this pull request Mar 13, 2016
Merged
@teameh
Copy link
Collaborator Author

teameh commented Mar 13, 2016

Closing this in favor of #62

  • We really don't want to rely on @@Redux/INIT or any other redux actions
  • We don't mind only saving to history if state changed (always apply distinct state filter)

@teameh teameh closed this Mar 13, 2016
@teameh teameh deleted the distinct_state_fixes branch March 14, 2016 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teameh @omnidan @pl12133