Review all CDI related workarounds against currently available servers #281

Closed
BalusC opened this Issue Jul 2, 2016 · 5 comments

Projects

None yet

2 participants

@BalusC
Member
BalusC commented Jul 2, 2016 edited
  • beans.xml was for long only CDI 1.0 in order to be TomEE 1.7.x compatible. Now TomEE 7.x is out for some time, it can be updated to CDI 1.1 and give us the opportunity to reliably use CDI.current().
  • WebXml and FacesConfigXml enums have some awkward initialization workaround in order to be WebLogic 12.1 compatible. Check if it can be removed for WebLogic 12.2.
  • Check if @Inject InjectionPoint workaround in all CDI producers can be removed in current OWB 1.6.3 version.
  • Check if any Beans#getReference() call can be replaced by @Inject or CDI.current().select() and still work in all current servers.
@arjantijms
Member

Check if @Inject InjectionPoint workaround in all CDI producers can be removed in current OWB 1.6.3 version.

If you mean the dynamic producers, then this was fixed in OWB, but unfortunately broke in Weld later again. See: https://issues.jboss.org/browse/CDI-610

@BalusC
Member
BalusC commented Jul 4, 2016

No, I didn't mean InjectionPointGenerator, I actually meant below construct as found in several producers such as RequestCookieProducer.

@Inject
private InjectionPoint injectionPoint; // Workaround for OWB not properly passing it as produce argument.

@Produces
@Cookie
public String produce(InjectionPoint injectionPoint) {
    // ...
}
@BalusC BalusC added a commit that referenced this issue Jul 4, 2016
@BalusC BalusC #281: switch to CDI 1.1 beans.xml 54584ee
@BalusC BalusC added a commit that referenced this issue Jul 15, 2016
@BalusC BalusC #281: move CDI check from ApplicationListener to ApplicationInitializer
(it was previously done in container listener because GF crashed when
JNDI was accessed in a container initializer; JNDI is not used anymore)
Additionally, explicitly check for JSF 2.2 as well.
4296912
@BalusC
Member
BalusC commented Jul 26, 2016

Also re-test all CDI functionality in multi-module EAR (two WARs in EAR) and update https://github.com/omnifaces/omnifaces/wiki/Known-Issues-(CDI)

@BalusC BalusC added a commit that referenced this issue Jul 28, 2016
@BalusC BalusC #281: simplified ViewScopeContext 64b0cbc
@BalusC
Member
BalusC commented Aug 6, 2016

Important news: since Weld 2.3.5 (https://issues.jboss.org/browse/WELD-2143) there are no anymore issues when using OmniFaces in multiple WARs in multi-module EAR!

@BalusC BalusC added a commit that referenced this issue Aug 15, 2016
@BalusC BalusC #281: Remove VetoAnnotatedTypeExtension.
(became obsolete since CDI 1.1 beans.xml <scan><exclude>)
bcbe51a
@BalusC BalusC added a commit that referenced this issue Aug 21, 2016
@BalusC BalusC #281: move back CDI check from context initializer to context listener
(it failed in Payara)
6e4bbb8
@BalusC BalusC added a commit that referenced this issue Aug 21, 2016
@BalusC BalusC #281: improved reworked @Eager @ApplicationScoped instantiation
(it failed in Payara)
3487f11
@BalusC
Member
BalusC commented Sep 2, 2016

Closing off as 2.5-RC1 has been released.

@BalusC BalusC closed this Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment