New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review all CDI related workarounds against currently available servers #281

Closed
BalusC opened this Issue Jul 2, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@BalusC
Member

BalusC commented Jul 2, 2016

  • beans.xml was for long only CDI 1.0 in order to be TomEE 1.7.x compatible. Now TomEE 7.x is out for some time, it can be updated to CDI 1.1 and give us the opportunity to reliably use CDI.current().
  • WebXml and FacesConfigXml enums have some awkward initialization workaround in order to be WebLogic 12.1 compatible. Check if it can be removed for WebLogic 12.2.
  • Check if @Inject InjectionPoint workaround in all CDI producers can be removed in current OWB 1.6.3 version.
  • Check if any Beans#getReference() call can be replaced by @Inject or CDI.current().select() and still work in all current servers.
@arjantijms

This comment has been minimized.

Show comment
Hide comment
@arjantijms

arjantijms Jul 2, 2016

Member

Check if @Inject InjectionPoint workaround in all CDI producers can be removed in current OWB 1.6.3 version.

If you mean the dynamic producers, then this was fixed in OWB, but unfortunately broke in Weld later again. See: https://issues.jboss.org/browse/CDI-610

Member

arjantijms commented Jul 2, 2016

Check if @Inject InjectionPoint workaround in all CDI producers can be removed in current OWB 1.6.3 version.

If you mean the dynamic producers, then this was fixed in OWB, but unfortunately broke in Weld later again. See: https://issues.jboss.org/browse/CDI-610

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC Jul 4, 2016

Member

No, I didn't mean InjectionPointGenerator, I actually meant below construct as found in several producers such as RequestCookieProducer.

@Inject
private InjectionPoint injectionPoint; // Workaround for OWB not properly passing it as produce argument.

@Produces
@Cookie
public String produce(InjectionPoint injectionPoint) {
    // ...
}
Member

BalusC commented Jul 4, 2016

No, I didn't mean InjectionPointGenerator, I actually meant below construct as found in several producers such as RequestCookieProducer.

@Inject
private InjectionPoint injectionPoint; // Workaround for OWB not properly passing it as produce argument.

@Produces
@Cookie
public String produce(InjectionPoint injectionPoint) {
    // ...
}

BalusC added a commit that referenced this issue Jul 4, 2016

BalusC added a commit that referenced this issue Jul 15, 2016

#281: move CDI check from ApplicationListener to ApplicationInitializer
(it was previously done in container listener because GF crashed when
JNDI was accessed in a container initializer; JNDI is not used anymore)
Additionally, explicitly check for JSF 2.2 as well.
@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC Jul 26, 2016

Member

Also re-test all CDI functionality in multi-module EAR (two WARs in EAR) and update https://github.com/omnifaces/omnifaces/wiki/Known-Issues-(CDI)

Member

BalusC commented Jul 26, 2016

Also re-test all CDI functionality in multi-module EAR (two WARs in EAR) and update https://github.com/omnifaces/omnifaces/wiki/Known-Issues-(CDI)

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC Aug 6, 2016

Member

Important news: since Weld 2.3.5 (https://issues.jboss.org/browse/WELD-2143) there are no anymore issues when using OmniFaces in multiple WARs in multi-module EAR!

Member

BalusC commented Aug 6, 2016

Important news: since Weld 2.3.5 (https://issues.jboss.org/browse/WELD-2143) there are no anymore issues when using OmniFaces in multiple WARs in multi-module EAR!

BalusC added a commit that referenced this issue Aug 15, 2016

#281: Remove VetoAnnotatedTypeExtension.
(became obsolete since CDI 1.1 beans.xml <scan><exclude>)

BalusC added a commit that referenced this issue Aug 21, 2016

BalusC added a commit that referenced this issue Aug 21, 2016

@BalusC

This comment has been minimized.

Show comment
Hide comment
@BalusC

BalusC Sep 2, 2016

Member

Closing off as 2.5-RC1 has been released.

Member

BalusC commented Sep 2, 2016

Closing off as 2.5-RC1 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment