o:validateBean on class-level broken in 2.5

[pvydra]

After upgrade to 2.5, o:validateBean stopped working on class-level validation.

<h:form>
...  
        <o:validateBean value="#{myBean.agreement}" />

        <p:commandButton update="@form" value="Button" action="# {myBean.save()}"  /> 
</h:form>

Stack: Wildfly 9, JSF 2.2, PrimeFaces 5.3

I've found out by debugging that method ValidateBean.processValidateBean(UIComponent component) in 2.4 contains following condition:

if (!form.equals(getCurrentForm()) || (component instanceof UICommand && !hasInvokedSubmit(component))) {
            return;
}

In 2.5 this condition has been changed to this

if (!form.equals(getCurrentForm()) || !hasInvokedSubmit(component)) {
            return;
}

Since hasInvokedSubmit returns (in both versions) false (because component is HtmlFormbut getCurrentActionSource() is UICommand) the condition always ends execution in 2.5.

[BalusC]

That was an awkward mistake. Can you please try today's latest 2.6 snapshot after its build has passed and confirm? Then I will release a 2.5.1.

[BalusC]

That was an awkward mistake. Can you please try today's latest 2.6 snapshot after its build has passed and confirm? Then I will release a 2.5.1.

[pvydra]

I can confirm it is working in 2.6-20160920.200801-3

[pvydra]

I can confirm it is working in 2.6-20160920.200801-3

[BalusC]

I have just released 2.5.1. It will be on Maven Central sooner or later today.

[BalusC]

I have just released 2.5.1. It will be on Maven Central sooner or later today.