-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PWA] WebAppManifest: screenshots and shortcuts support #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebAppManifest Screenshots and Shortcuts Signed-off-by: pizzi80 <paolo@given2.com>
pizzi80
changed the title
[PWA] WebAppManifest: screenshots and shorcuts support
[PWA] WebAppManifest: screenshots and shortcuts support
Apr 15, 2024
BalusC
reviewed
May 5, 2024
src/main/java/org/omnifaces/resourcehandler/WebAppManifest.java
Outdated
Show resolved
Hide resolved
BalusC
reviewed
May 5, 2024
src/main/java/org/omnifaces/resourcehandler/WebAppManifest.java
Outdated
Show resolved
Hide resolved
BalusC
reviewed
May 5, 2024
BalusC
reviewed
May 5, 2024
BalusC
reviewed
May 5, 2024
src/main/java/org/omnifaces/resourcehandler/WebAppManifest.java
Outdated
Show resolved
Hide resolved
BalusC
reviewed
May 5, 2024
BalusC
reviewed
May 5, 2024
missing @Version Signed-off-by: pizzi80 <paolo@given2.com>
There are test failures
|
Signed-off-by: pizzi80 <paolo@given2.com>
should be fixed ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to follow the documentation standard (which is very informative btw 馃憤 )