Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA] WebAppManifest: screenshots and shortcuts support #799

Merged
merged 3 commits into from
May 6, 2024

Conversation

pizzi80
Copy link
Contributor

@pizzi80 pizzi80 commented Apr 15, 2024

  • WebAppManifest Screenshots and Shortcuts
  • "final" on inner classes effective final fields
  • typo

I tried to follow the documentation standard (which is very informative btw 馃憤 )

WebAppManifest Screenshots and Shortcuts

Signed-off-by: pizzi80 <paolo@given2.com>
@pizzi80 pizzi80 changed the title [PWA] WebAppManifest: screenshots and shorcuts support [PWA] WebAppManifest: screenshots and shortcuts support Apr 15, 2024
missing @Version

Signed-off-by: pizzi80 <paolo@given2.com>
@BalusC
Copy link
Member

BalusC commented May 6, 2024

There are test failures

Error:  Failures: 
Error:    PWAResourceHandlerIT.verifyManifest:67 expected: <{"categories":[],"dir":"auto","display":"browser","icons":[{"sizes":"512x512","src":"\/PWAResourceHandlerIT\/jakarta.faces.resource\/icon.png.xhtml?v=1","type":"image\/png"}],"lang":"en","name":"PWAResourceHandlerIT","orientation":"any","prefer_related_applications":false,"related_applications":[],"start_url":"http:\/\/127.0.0.1:8080\/PWAResourceHandlerIT\/"}> but was: <{"categories":[],"dir":"auto","display":"browser","icons":[{"sizes":"512x512","src":"\/PWAResourceHandlerIT\/jakarta.faces.resource\/icon.png.xhtml?v=1","type":"image\/png"}],"lang":"en","name":"PWAResourceHandlerIT","orientation":"any","prefer_related_applications":false,"related_applications":[],"screenshots":[],"shortcuts":[],"start_url":"http:\/\/127.0.0.1:8080\/PWAResourceHandlerIT\/"}>
[INFO] 
Error:  Tests run: 143, Failures: 1, Errors: 0, Skipped: 2

@pizzi80
Copy link
Contributor Author

pizzi80 commented May 6, 2024

should be fixed ...

@BalusC BalusC merged commit ce82666 into omnifaces:4.x May 6, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants