Remove scalar typehint from AmazonSES constructor #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahariaazam
requested changes
Aug 17, 2020
src/AmazonSES.php
Outdated
| @@ -134,7 +134,7 @@ public function setSignatureVersion($signatureVersion) | |||
| * @param bool $verifyHost | |||
| * @param LoggerInterface|null $logger | |||
| */ | |||
| public function __construct($accessKey = null, $secretKey = null, $host = self::AWS_US_EAST_1, $verifyPeer = true, $verifyHost = true, LoggerInterface $logger = null, string $signatureVersion = SimpleEmailService::REQUEST_SIGNATURE_V4) | |||
| public function __construct($accessKey = null, $secretKey = null, $host = self::AWS_US_EAST_1, $verifyPeer = true, $verifyHost = true, LoggerInterface $logger = null, string $signatureVersion = 'v4') | |||
There was a problem hiding this comment.
I was talking about scalar type hinting.
Can you please remove string in front of parameter?
public function __construct(. . . . . . . string $signatureVersion = 'v4')
{
}
I think it should be like
public function __construct(. . . . . . . $signatureVersion = SimpleEmailService::REQUEST_SIGNATURE_V4) // <----- removed string as string is scalar type
{
}
For constant I think you can keep the constant as it was before.
- Also it would be great if phpdoc block is updated.
|
Seems OK. Going to approve this. Thanks @stevecoug for your time. Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42