Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a disconnectAsync method #141

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Adding a disconnectAsync method #141

wants to merge 7 commits into from

Conversation

christopher-w-root
Copy link
Contributor

Merge Checklist

🔧 Issue(s) fixed:

  • Author referenced issue(s) fixed by this PR:
  • Fixes #0

🚬 Smoke Test

  • Works in chrome
  • Works in firefox
  • Works in safari
  • Works in ie edge
  • Works in ie 11

🚢 Merge

  • author crafted PR's title into release-worthy commit message.

@christopher-w-root christopher-w-root force-pushed the chris/disconnect_async branch 2 times, most recently from 0b3ae01 to dc1e889 Compare April 11, 2019 15:09
@christopher-w-root
Copy link
Contributor Author

retest this please

@christopher-w-root christopher-w-root force-pushed the chris/disconnect_async branch 2 times, most recently from 897ea92 to 3199217 Compare September 13, 2019 17:34
Throws an error on thrift node connector errors rather than it going …
8898abb 
…unchecked by sending it

to console.error. This will make it easier to take the appropriate action on server crashes
during test runs.
@israelvicars
Copy link
Contributor

@vastcharade Can we close this PR for now?

@christopher-w-root
Copy link
Contributor Author

Yeah, i guess so, particularly since it's so old. Has a disconnect_async method been added in the meantime, or is that functionality still missing? Just so you're aware, I I still actively use my chris/disconnect_async branch. It is used as a backbone for our funtional render test suite. It'd be nice to get the changes I've made in that branch merged into mainline so I don't have to rely on maintaining it anymore. It mostly contains adding support for endpoints that weren't there before, like disconnect_async, clear_gpu_mem, and a couple more.

@christopher-w-root
Copy link
Contributor Author

christopher-w-root commented Jan 11, 2021 •
edited

nope, still no async disconnect from what I can tell.

@israelvicars
Copy link
Contributor

@vastcharade Sounds like we should keep it open until those points are resolved. It'd definitely better to add the support you need. Sorry you've had to maintain the separate branch for all this time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonvuri jonvuri Awaiting requested review from jonvuri

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christopher-w-root @israelvicars @mapd-bot