Expose Structure #11
Merged
Expose Structure #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The advantage of having var Structure = require('immstruct/src/structure');Or changing this to var Structure = require('immstruct/structure');is that you wouldn't have to load the "entire" immstruct code. It's not that big, but the concept of it. Especially for usage with browserify. |
|
Good point. Hadn't thought of that. I think I rebased with alternative changes. |
|
Good change! |
mikaelbr
added a commit
that referenced
this pull request
Dec 18, 2014
Exposes structure as public API.
|
Added documentation here: 889f7b2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #10 (comment).
I think
var Structure = require('immstruct').Structure;is better thanvar Structure = require('immstruct/src/structure');.