Simplify base changeListener.
#29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When handling resync of stale cursors with the underlying immutable structure (e.g map), we need to handle three cases based on the given keyPath indicating a change: 1. keyPath is not in the updated map, but it exists in the current (removal) 2. keyPath is in the updated map, but it doesn't exist in the current (add) 3. keyPath is in the updated map, but it also exists in the current For the first case, we need to use `Immutable.Map.removeIn`. While `Immutable.Map.setIn` is sufficient for the other cases. Using methods of simplifying boolean expressions (e.g. K-maps), we can just test keyPath is not in the updated map to handle logic flow.
|
Thanks to @Gozala for bringing this up. |
|
This relies on knowing the following: https://github.com/facebook/immutable-js/blob/691ad67eff57d2addd739848c195140e6f488f94/src/Map.js#L58-L60 Correctness should be the same overall. |
|
Looks good to me! |
mikaelbr
added a commit
that referenced
this pull request
Feb 5, 2015
Simplifies updating structure on `changeListener`.
|
Thanks! Looks good. Less code is great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling resync of stale cursors with the underlying immutable structure (e.g map),
we need to handle three cases based on the given keyPath indicating a change:
For the first case, we need to use
Immutable.Map.removeIn.While
Immutable.Map.setInis sufficient for the other cases.Using methods of simplifying boolean expressions (e.g. K-maps), we can just test
keyPath is not in the updated map to handle logic flow.