Omnisharp server takes 100% CPU

[chtenb]

I don't know if Omnisharp can be blamed for this, but everytime I start the server, the cli process (which is mono runtime) takes up 100% CPU usage.
This is certainly an unwanted thing.
I'm on Linux.

[nosami]

Just tried on Windows.... server sits at 0% when not in use. I'm not at my linux box to try it out.

Do you think 56bcb87 could have caused this?

[chtenb]

I cannot be due to 56bcb87, since the while only loops when a line is entered, which doesn't happen generally.

[nosami]

I didn't think it would be that to be honest... just clutching at straws. Do you know if the 100% cpu usage is a recent issue?

I'd be interested to know if anyone else has this problem.

[chtenb]

I just noticed that the problem doesn't occur when starting the server outside vim. Let me dig into this a little more.

[chtenb]

I don't know if its a recent issue, since I could only get it working very recently. Could it have something todo with the way vim-dispatch is called, or with vim-dispatch itself?

[nosami]

I wouldn't imagine it was vim-dispatch related although I can't explain how starting the server outside vim would change anything. Sorry.

[chtenb]

I found its not vim-dispatch related, since running the server manually by :!Omnisharp.exe -s mysolution.sln & results in 100% CPU usage as well.

[nosami]

I parse the solution in a background thread now since ed19c02. Maybe that is causing the problem.

[chtenb]

As far as I can understand things now, it actually IS related to the while loop in 56bcb87 .
What happens (I guess) is that starting the server from within vim causes Console.ReadLine() to pass immediately, making the while statement loop very fast.

Thinking about a solution for this, I think we actually don't want to test stdin for input since that happens to lead to unwanted behaviour on different systems. I think we just want to have NancyHost running forever, until it is given a shutdown signal from port 2000 (or whatever the configured port is). Just like is done with windows forms when the Appliction.Run() method is invoked.

Could something similar be done for nancyhost? That would solve all these problems.

[nosami]

Not sure about the long term fix yet, but for now a simple Thread.Sleep(500) inside the while loop will sort your problem out.

[nosami]

Just pushed quick fix.