Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] files not synced into single folder when Folder options set #219

Closed
ruinshe opened this issue Apr 16, 2024 · 7 comments
Closed

[BUG] files not synced into single folder when Folder options set #219

ruinshe opened this issue Apr 16, 2024 · 7 comments
Assignees

Comments

@ruinshe
Copy link

ruinshe commented Apr 16, 2024

Currently the default sync destination is set as Omnivore/{{{date}}}, but I found Omnivore-{{{date}}} folders created instead of all files begin placed into Omnivore folder.

What I want the synced folder looks like:

.
├── Omnivore
│   ├── 2024-04-08
│   ├── 2024-04-09
│   ├── 2024-04-10
│   ├── 2024-04-14
│   ├── 2024-04-15
│   └── 2024-04-16
...

And actual synced files:

.
├── Omnivore-2024-04-08
├── Omnivore-2024-04-09
├── Omnivore-2024-04-10
├── Omnivore-2024-04-14
├── Omnivore-2024-04-15
├── Omnivore-2024-04-16
...
@thatside
Copy link

thatside commented Apr 16, 2024

unfortunately this seems to be caused by #211 - the fix is replacing forward slash as well as space symbols

I'll try to take a look later but can't guarantee anything as I have no experience with Obsidian plugins

@fpehar
Copy link

fpehar commented Apr 16, 2024

After the update, I have the same issue: I can't store the notes in a subfolder

@Eng4G3
Copy link

Eng4G3 commented Apr 17, 2024

I am having the same or similar issue. Installed the Obsidian plugin yesterday with the file path set to:

03-Resources/Zett

but when it syncs it is actually creating a new folder and populating it: 03-Resources-Zett

Tesselay added a commit to Tesselay/obsidian-omnivore-folderregexfix that referenced this issue Apr 17, 2024
@sywhb sywhb self-assigned this Apr 18, 2024
sywhb pushed a commit that referenced this issue Apr 18, 2024
* Add separate illegal char regex for folders

* Fix correct folder path separators being replaced

Issue #219
sywhb pushed a commit that referenced this issue Apr 18, 2024
* Add separate illegal char regex for folders

* Fix correct folder path separators being replaced

Issue #219
sywhb added a commit that referenced this issue Apr 18, 2024
github-actions bot pushed a commit that referenced this issue Apr 18, 2024
## [1.10.1](1.10.0...1.10.1) (2024-04-18)

### Bug Fixes

* folder path separators are incorrectly replaced ([5d6bf4f](5d6bf4f)), closes [#219](#219)
@sywhb
Copy link
Collaborator

sywhb commented Apr 18, 2024

Hey guys, sorry for the mess.

I just released a new version 1.10.1 to fix this bug. Credits to @Tesselay for the speedy response!

cc: @fpehar @ruinshe @thatside @Eng4G3 @StrollStars

@Tesselay
Copy link
Contributor

Glad I could help!

@StrollStars
Copy link

@sywhb Thank you very much!

@ruinshe
Copy link
Author

ruinshe commented Apr 18, 2024

Thanks! I upgraded and verified the issue is gone in latest version of Obsidian plugin, closing this issue.

@ruinshe ruinshe closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants
@fpehar @ruinshe @thatside @StrollStars @sywhb @Tesselay @Eng4G3 and others