bulk deleting function doesn't work

[jostyee]

On the web app, select multiple items and click the delete button

it says 'Items deleted' but none of them get deleted actually.

[jacksonh]

Are they still there if you refresh?

[jostyee]

Are they still there if you refresh?

yes there are, it's been over 2days and I've tried countless times:

1. use custom query to find out the items I don't want any more
2. select all or multiple
3. click the delete button
4. refresh webpage, nothing changes

[jacksonh]

Do you mind opening the developer console and looking for any errors? Both on the console tab and the network tab? If there is anything private you can either obscure it in the screenshot or send through the feedback tool

[jacksonh]

Thanks, it does look like everything went right there. Can you also try just a simple search like in:inbox with no label filters or anything to see if the items display?

[jacksonh]

Going to assign this one to @sywhb to look into more. Based on the data here I do see the correct call being made, but the library item status not being updated on the backend.

[jacksonh]

Going to delete this HAR file too as it includes some authentication info

[jostyee]

Thanks, it does look like everything went right there. Can you also try just a simple search like in:inbox with no label filters or anything to see if the items display?

it works for in:inbox

[jacksonh]

@jostyee thanks. Can you add the search query here that isn't working?

[jostyee]

@jacksonh the query is in:archive author:admin , ty.

[jacksonh]

I think maybe the core error here is no:label creates an exception with our new search parser. /cc @sywhb

[jostyee]

@jacksonh I don't think so, see my updated reply #3292 (comment) w/o no:label the function doesn't work, neither.

[sywhb]

hey @jacksonh, the delete function was failed because a recent change we made (default scope is in:inbox instead of in:all) and @jostyee was trying to delete items from archive folder so the params of the api were includes:id which converts to in:inbox includes:id and then no items were actually deleted

[jacksonh]

ahhh so on the web client i should change this, taking a look at it now

[sywhb]

i think we probably should revert this change so defaults to in:all if no folder is defined but it creates some other problems with saved searches like no:label or type:file which we want to show only unarchived items

[sywhb]

ahhh so on the web client i should change this, taking a look at it now

no, it's something i changed in the backend here #3276

[jacksonh]

Hmm, yeah i do think that patch is correct but we probably need to update defaults in a bunch of places.

[sywhb]

Hmm, yeah i do think that patch is correct but we probably need to update defaults in a bunch of places.

oh okay. like when you selected multiple items, the query should be in:all includes:id1,id2

[jacksonh]

Yeah, or maybe whenever includes is used we should use in:all

[sywhb]

Yeah, or maybe whenever includes is used we should use in:all

yeah, sounds right

[jostyee]

Yeah, or maybe whenever includes is used we should use in:all

should be, otherwise tabs such as highlights won't show archive items, and I have to adjust the Obsidian sync plugin query to fetch them.

[sywhb]

@jostyee, we just fixed this. could you please check again?

[jostyee]

@sywhb confirmed fixed, thank you again.